Attempt to add the browse page link to eLife navigation#3258
Merged
3mcd merged 1 commit intoknowledgefutures:masterfrom Mar 11, 2025
Merged
Attempt to add the browse page link to eLife navigation#32583mcd merged 1 commit intoknowledgefutures:masterfrom
3mcd merged 1 commit intoknowledgefutures:masterfrom
Conversation
Contributor
Author
|
@3mcd As noted above we have not been able to check if this breaks anything. We are happy to check it with your help or trust your judgement on when to merge this. |
Collaborator
|
@erkannt Sorry about that! I think this change is good to merge. I will check it out on our test environment before promoting the change to production! |
3mcd
approved these changes
Mar 11, 2025
Contributor
|
Looks good on the test environment: https://elife-container.duqduq.org/about When can we expect this to rolled out to production? |
gabestein
pushed a commit
that referenced
this pull request
Apr 1, 2025
elifesciences/issues#9146 Co-authored-by: David Moulton <d.moulton@elifesciences.org>
davidcmoulton
added a commit
to elifesciences/pubpub
that referenced
this pull request
May 21, 2025
Attempt to add the browse page link to eLife navigation (knowledgefutures#3258)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
We are currently rolling out a new URL link in the elifesciences.org site header.
https://github.com/elifesciences/issues/issues/9146
Concerns
We have not been able to test the change locally, as no-one of our team of four was able to to run an instance of PubPub or Storybook locally. #3257