Merged
Conversation
isTravis
approved these changes
Jul 17, 2024
Member
isTravis
left a comment
There was a problem hiding this comment.
I added one commit to adjust the height of the background on the landing page. It covers the white gap that showed up on larger screens between the hero section and the footer.
Suggested tests all worked on my end! Looks good.
isTravis
approved these changes
Jul 17, 2024
gabestein
added a commit
that referenced
this pull request
Apr 1, 2025
* redo landing page and remove some old routes * get rid of landing page lint errors * remove community creation links * require superadmin to create community * update links to kf.org * Adjust jumbotron height * update footer link * fix tests * better test fix * ok actually do real tests fine gabe does tod now * sigh spell it right * I love tests --------- Co-authored-by: Travis Rich <travis.s.rich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Updates our landing page to reflect PubPub Platform, and restricts new community creation to superAdmins.
Test Plan
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs