Conversation
ayushchauhan101
approved these changes
Jun 9, 2023
ayushchauhan101
left a comment
There was a problem hiding this comment.
Please try to replace var and use const or let.
Contributor
Author
|
@ayushchauhan101 made changes. please take a look |
ayushchauhan101
approved these changes
Jun 18, 2023
Member
|
A lot can be improved in the code also a few edge cases can be added. I am approving it for now and adding an issue for improvement. Thanks for the contributions @Ahtaxam and @ayushchauhan101 |
ashokdey
approved these changes
Jun 18, 2023
src/_Problems_/3Sum/3sum.js
Outdated
| @@ -0,0 +1,39 @@ | |||
| var threeSum = function(nums) { | |||
Member
There was a problem hiding this comment.
Would be great if we can add the problem statement as a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.