Skip to content

clean up OWNER files#13668

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:serving-owners
Feb 3, 2023
Merged

clean up OWNER files#13668
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:serving-owners

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Feb 3, 2023

  • Dropping networking as owners as it's been rolled into serving

@knative-prow knative-prow Bot added area/API API objects and controllers area/autoscale area/monitoring size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Feb 3, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@knative-prow knative-prow Bot requested review from andrew-su, carlisia and julz February 3, 2023 15:42
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 3, 2023

/assign @psschwei

Copy link
Copy Markdown
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2023

Codecov Report

Base: 86.24% // Head: 86.19% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7532ef8) compared to base (f6ab591).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13668      +/-   ##
==========================================
- Coverage   86.24%   86.19%   -0.05%     
==========================================
  Files         197      197              
  Lines       14783    14783              
==========================================
- Hits        12749    12742       -7     
- Misses       1733     1738       +5     
- Partials      301      303       +2     
Impacted Files Coverage Δ
pkg/autoscaler/statforwarder/processor.go 88.00% <0.00%> (-6.00%) ⬇️
pkg/autoscaler/statforwarder/forwarder.go 90.66% <0.00%> (-5.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow Bot merged commit b4d7a28 into knative:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/monitoring area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants