Skip to content

Adds slack links to CNCF Knative slack channel#13655

Merged
knative-prow[bot] merged 5 commits intoknative:mainfrom
vishal-chdhry:slack-update
Feb 1, 2023
Merged

Adds slack links to CNCF Knative slack channel#13655
knative-prow[bot] merged 5 commits intoknative:mainfrom
vishal-chdhry:slack-update

Conversation

@vishal-chdhry
Copy link
Copy Markdown
Contributor

Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com

Proposed Changes

Adds link to the Knative CNCF Slack Channel

  • This PR adds link to the CNCF Knative Slack channel.
  • adds link to #knative-serving

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jan 26, 2023

Welcome @vishal-chdhry! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jan 26, 2023

Hi @vishal-chdhry. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow Bot requested review from carlisia and skonto January 26, 2023 16:43
Comment thread support/COMMUNITY_CONTACTS.md Outdated
Comment thread support/support.rotation Outdated
Comment thread README.md Outdated
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Comment thread support/COMMUNITY_CONTACTS.md Outdated
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Comment thread README.md Outdated
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
@psschwei
Copy link
Copy Markdown
Member

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 31, 2023

Codecov Report

Base: 86.21% // Head: 86.22% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c2c0e16) compared to base (897b61a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13655      +/-   ##
==========================================
+ Coverage   86.21%   86.22%   +0.01%     
==========================================
  Files         197      197              
  Lines       14727    14783      +56     
==========================================
+ Hits        12697    12747      +50     
- Misses       1730     1735       +5     
- Partials      300      301       +1     
Impacted Files Coverage Δ
pkg/apis/serving/fieldmask.go 94.91% <0.00%> (-0.70%) ⬇️
pkg/activator/net/revision_backends.go 92.19% <0.00%> (-0.58%) ⬇️
pkg/apis/config/features.go 95.52% <0.00%> (+0.13%) ⬆️
pkg/apis/serving/v1/revision_defaults.go 97.43% <0.00%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psschwei
Copy link
Copy Markdown
Member

/test unit-tests

1 similar comment
@psschwei
Copy link
Copy Markdown
Member

/test unit-tests

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Feb 1, 2023

/lgtm
/approve

I'll do some follow ups in another PR

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Vishal-Chdhry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@knative-prow knative-prow Bot merged commit f6ab591 into knative:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants