Adds slack links to CNCF Knative slack channel#13655
Adds slack links to CNCF Knative slack channel#13655knative-prow[bot] merged 5 commits intoknative:mainfrom
Conversation
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
Welcome @vishal-chdhry! It looks like this is your first PR to knative/serving 🎉 |
|
Hi @vishal-chdhry. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
/ok-to-test |
Codecov ReportBase: 86.21% // Head: 86.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13655 +/- ##
==========================================
+ Coverage 86.21% 86.22% +0.01%
==========================================
Files 197 197
Lines 14727 14783 +56
==========================================
+ Hits 12697 12747 +50
- Misses 1730 1735 +5
- Partials 300 301 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/test unit-tests |
1 similar comment
|
/test unit-tests |
|
/lgtm I'll do some follow ups in another PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, Vishal-Chdhry The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com
Proposed Changes
Adds link to the Knative CNCF Slack Channel