Skip to content

Move S2I scaffolding from .s2i/ to .func/build/ for go/python runtimes.#3436

Draft
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-nnvsznoykpvn
Draft

Move S2I scaffolding from .s2i/ to .func/build/ for go/python runtimes.#3436
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-nnvsznoykpvn

Conversation

@gauron99
Copy link
Contributor

  • Move the generated .s2i/* files during s2i build with scaffold-enabled runtimes into .func/build to align it with the other builders. All should now be the same.
  • Update Tekton pipelines to use custom assemble scripts for Go/Python

@knative-prow
Copy link

knative-prow bot commented Feb 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2026
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 63.82979% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.97%. Comparing base (53dcc03) to head (8671e88).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scaffolding/scaffold.go 54.54% 7 Missing and 3 partials ⚠️
pkg/s2i/scaffolder.go 50.00% 1 Missing and 2 partials ⚠️
pkg/oci/scaffolder.go 0.00% 1 Missing and 1 partial ⚠️
pkg/pipelines/tekton/templates.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
- Coverage   54.51%   51.97%   -2.54%     
==========================================
  Files         179      179              
  Lines       20274    20308      +34     
==========================================
- Hits        11052    10556     -496     
- Misses       8050     8673     +623     
+ Partials     1172     1079      -93     
Flag Coverage Δ
e2e 38.48% <51.42%> (+0.04%) ⬆️
e2e go 32.68% <51.42%> (+0.05%) ⬆️
e2e node 28.50% <14.28%> (-0.04%) ⬇️
e2e python 32.10% <20.00%> (-0.04%) ⬇️
e2e quarkus 28.65% <14.28%> (-0.04%) ⬇️
e2e rust 28.04% <5.71%> (-0.06%) ⬇️
e2e springboot 26.53% <5.71%> (-0.04%) ⬇️
e2e typescript 28.62% <14.28%> (-0.04%) ⬇️
integration ?
unit macos-14 42.37% <54.28%> (+0.13%) ⬆️
unit macos-latest 42.37% <54.28%> (+0.13%) ⬆️
unit ubuntu-24.04-arm 42.65% <59.57%> (+0.11%) ⬆️
unit ubuntu-latest 43.26% <54.28%> (+0.13%) ⬆️
unit windows-latest 42.39% <54.28%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad to see us using .func consistently now

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@matejvasek
Copy link
Contributor

note: podman failure is related to this PR, override it

@knative-prow
Copy link

knative-prow bot commented Feb 14, 2026

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99 gauron99 force-pushed the push-nnvsznoykpvn branch 4 times, most recently from 7daedf5 to 0ffeddd Compare February 17, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments