refactor: big string literals to separate files#3388
Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom Jan 23, 2026
Merged
refactor: big string literals to separate files#3388knative-prow[bot] merged 2 commits intoknative:mainfrom
knative-prow[bot] merged 2 commits intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
PTAL @gauron99 @lkingland |
40aeba6 to
93e3d7b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3388 +/- ##
==========================================
- Coverage 54.74% 54.53% -0.22%
==========================================
Files 173 173
Lines 20112 19694 -418
==========================================
- Hits 11011 10740 -271
+ Misses 7992 7833 -159
- Partials 1109 1121 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
93e3d7b to
41513c6
Compare
Reformat yamls using "yq -i '.'" so if we need to patch them in future we can do "semantic" patching using yq and still have nice diff. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
go:embedon these.fmt.Sprintf().yq.