Skip to content

Comments

fix: presubmit unit tests#3367

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-nuvlspqrzqrp
Jan 16, 2026
Merged

fix: presubmit unit tests#3367
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-nuvlspqrzqrp

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jan 16, 2026

/fix #3260

  • bump the prow-images image which fixes the initial issue reported in the 3260
  • add /tmp/.. cache dir for npm. Previously it was /root/.npm (because of the docker) -- This causes npm ERR! Your cache folder contains root-owned files

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2026
@gauron99 gauron99 requested review from lkingland, matejvasek and twoGiants and removed request for dsimansk and jrangelramos January 16, 2026 16:15
@gauron99 gauron99 changed the title presubmit issue #2 fix: presubmit unit tests Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.19%. Comparing base (f508122) to head (dc7cf0c).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3367      +/-   ##
==========================================
+ Coverage   55.14%   55.19%   +0.04%     
==========================================
  Files         170      170              
  Lines       19970    19963       -7     
==========================================
+ Hits        11013    11019       +6     
+ Misses       7880     7863      -17     
- Partials     1077     1081       +4     
Flag Coverage Δ
e2e 39.74% <ø> (+0.34%) ⬆️
e2e go 35.48% <ø> (+0.04%) ⬆️
e2e node 31.12% <ø> (+0.14%) ⬆️
e2e python 35.12% <ø> (+0.03%) ⬆️
e2e quarkus 31.25% <ø> (+0.12%) ⬆️
e2e rust 30.71% <ø> (+0.14%) ⬆️
e2e springboot 29.20% <ø> (-1.42%) ⬇️
e2e typescript 31.23% <ø> (+0.14%) ⬆️
integration 17.41% <ø> (-0.07%) ⬇️
unit macos-14 45.11% <ø> (+<0.01%) ⬆️
unit macos-latest 45.11% <ø> (+<0.01%) ⬆️
unit ubuntu-24.04-arm 45.23% <ø> (+0.02%) ⬆️
unit ubuntu-latest 46.00% <ø> (+<0.01%) ⬆️
unit windows-latest 45.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 62cbaaf into knative:main Jan 16, 2026
39 checks passed
24aysh pushed a commit to 24aysh/func that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make presubmit-unit-tests fails locally

2 participants