Skip to content

Comments

Use bundles resolver instead of http for git-clone#3365

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
matejvasek:use-bundles-resolver
Jan 15, 2026
Merged

Use bundles resolver instead of http for git-clone#3365
knative-prow[bot] merged 2 commits intoknative:mainfrom
matejvasek:use-bundles-resolver

Conversation

@matejvasek
Copy link
Contributor

Changes

  • Use bundles resolver instead of http for git-clone

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2026
Copy link
Contributor

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 😸 👍

I warms my geek heart 😻 .

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@twoGiants
Copy link
Contributor

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2026
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
@twoGiants
Copy link
Contributor

/unhold
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.10%. Comparing base (d1c611a) to head (d7d583b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3365      +/-   ##
==========================================
- Coverage   55.12%   55.10%   -0.02%     
==========================================
  Files         170      170              
  Lines       19955    19963       +8     
==========================================
+ Hits        11000    11001       +1     
- Misses       7879     7883       +4     
- Partials     1076     1079       +3     
Flag Coverage Δ
e2e 39.37% <100.00%> (+0.03%) ⬆️
e2e go 35.41% <100.00%> (+0.03%) ⬆️
e2e node 30.96% <100.00%> (+0.03%) ⬆️
e2e python 35.07% <100.00%> (+0.03%) ⬆️
e2e quarkus 31.11% <100.00%> (+0.03%) ⬆️
e2e rust 30.55% <100.00%> (+0.02%) ⬆️
e2e springboot 30.60% <100.00%> (+0.03%) ⬆️
e2e typescript 31.07% <100.00%> (+0.03%) ⬆️
integration 17.41% <100.00%> (+0.01%) ⬆️
unit macos-14 45.11% <100.00%> (+0.03%) ⬆️
unit macos-latest 45.11% <100.00%> (+0.02%) ⬆️
unit ubuntu-24.04-arm 45.23% <100.00%> (+0.02%) ⬆️
unit ubuntu-latest 46.00% <100.00%> (+0.02%) ⬆️
unit windows-latest 45.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot merged commit c9b015e into knative:main Jan 15, 2026
43 checks passed
24aysh pushed a commit to 24aysh/func that referenced this pull request Jan 21, 2026
* Use bundles resolver instead of http for git-clone

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

* remove invalid param

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

---------

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants