Fix: add middleware version label in remote build too#3289
Merged
knative-prow[bot] merged 5 commits intoknative:mainfrom Dec 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
=======================================
Coverage 54.76% 54.76%
=======================================
Files 168 168
Lines 19594 19605 +11
=======================================
+ Hits 10730 10737 +7
- Misses 7800 7804 +4
Partials 1064 1064
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In #3270 we added the label of the used middleware version to the built image. Unfortunately I did not add it for remote builds too. This PR addresses it and updates the remote builds (s2i) to add the label too.
Therefor the used middleware version is a result of the
scaffoldtekton task and will be passed to thebuildtask, which has the possibility to add the labels (we can't do that during scaffolding where we have this information)./kind bug
/cc @matejvasek