Skip to content

Comments

Update build command to disable VCS information#3285

Merged
knative-prow[bot] merged 1 commit intomainfrom
matejvasek-patch-3
Dec 10, 2025
Merged

Update build command to disable VCS information#3285
knative-prow[bot] merged 1 commit intomainfrom
matejvasek-patch-3

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Dec 10, 2025

Changes

  • Make func-utils binary more reproducible by not including VCS info. This should limit image version proliferation.
    Without this change each push to main generates new images even when func-utils binary did not really change.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.74%. Comparing base (03e6a5b) to head (ad3dc5f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3285      +/-   ##
==========================================
- Coverage   54.76%   54.74%   -0.03%     
==========================================
  Files         168      168              
  Lines       19594    19594              
==========================================
- Hits        10730    10726       -4     
- Misses       7800     7802       +2     
- Partials     1064     1066       +2     
Flag Coverage Δ
e2e 40.30% <ø> (ø)
e2e go 36.26% <ø> (ø)
e2e node 31.70% <ø> (ø)
e2e python 35.99% <ø> (ø)
e2e quarkus 31.86% <ø> (ø)
e2e rust 31.31% <ø> (ø)
e2e springboot 31.34% <ø> (ø)
e2e typescript 31.82% <ø> (ø)
integration 17.69% <ø> (-0.02%) ⬇️
unit macos-14 44.39% <ø> (ø)
unit macos-latest 44.39% <ø> (ø)
unit ubuntu-24.04-arm 44.59% <ø> (ø)
unit ubuntu-latest 45.31% <ø> (ø)
unit windows-latest 44.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

/override actionlint

@knative-prow
Copy link

knative-prow bot commented Dec 10, 2025

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

Details

In response to this:

/override actionlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTH?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland
Copy link
Member

/override actionlint

@knative-prow
Copy link

knative-prow bot commented Dec 10, 2025

@lkingland: Overrode contexts on behalf of lkingland: actionlint

Details

In response to this:

/override actionlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 07092aa into main Dec 10, 2025
39 of 40 checks passed
@matejvasek matejvasek deleted the matejvasek-patch-3 branch December 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants