Skip to content

Fix architecture variable in build command#3282

Merged
knative-prow[bot] merged 1 commit intomainfrom
matejvasek-patch-2
Dec 9, 2025
Merged

Fix architecture variable in build command#3282
knative-prow[bot] merged 1 commit intomainfrom
matejvasek-patch-2

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Dec 9, 2025

reintroducing #2843
somehow it was reverted is some refactor

@matejvasek matejvasek requested a review from lkingland December 9, 2025 17:34
@knative-prow knative-prow bot requested a review from dsimansk December 9, 2025 17:34
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@knative-prow knative-prow bot requested a review from jrangelramos December 9, 2025 17:34
@matejvasek matejvasek requested review from gauron99 and removed request for dsimansk and jrangelramos December 9, 2025 17:34
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2025
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland @jrangelramos

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.53%. Comparing base (c6bac50) to head (816cb2b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3282   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files         167      167           
  Lines       19512    19512           
=======================================
+ Hits        10640    10641    +1     
+ Misses       7811     7810    -1     
  Partials     1061     1061           
Flag Coverage Δ
e2e 39.70% <ø> (ø)
e2e go 35.72% <ø> (ø)
e2e node 30.97% <ø> (ø)
e2e python 35.39% <ø> (ø)
e2e quarkus 31.11% <ø> (-0.02%) ⬇️
e2e rust 30.57% <ø> (ø)
e2e springboot 30.60% <ø> (ø)
e2e typescript 31.09% <ø> (ø)
integration 17.64% <ø> (+<0.01%) ⬆️
unit macos-14 44.46% <ø> (ø)
unit macos-latest 44.46% <ø> (ø)
unit ubuntu-24.04-arm 44.67% <ø> (ø)
unit ubuntu-latest 45.38% <ø> (ø)
unit windows-latest 44.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

/override ?

@knative-prow
Copy link

knative-prow bot commented Dec 9, 2025

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

Details

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland
Copy link
Member

/override actionlint

@knative-prow
Copy link

knative-prow bot commented Dec 9, 2025

@lkingland: Overrode contexts on behalf of lkingland: actionlint

Details

In response to this:

/override actionlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative knative deleted a comment from knative-prow bot Dec 9, 2025
@knative knative deleted a comment from knative-prow bot Dec 9, 2025
@knative-prow knative-prow bot merged commit adf8797 into main Dec 9, 2025
39 of 40 checks passed
@matejvasek matejvasek deleted the matejvasek-patch-2 branch December 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments