Skip to content

Better documentation for git hooks.#3279

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:githooks
Dec 10, 2025
Merged

Better documentation for git hooks.#3279
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:githooks

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Dec 8, 2025

Changes

  • Better documentation for git hooks.
  • Moved docs/CONTRIBUTING.md => CONTRIBUTING.md

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.52%. Comparing base (c47c428) to head (828e58a).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
- Coverage   54.53%   54.52%   -0.02%     
==========================================
  Files         167      167              
  Lines       19473    19512      +39     
==========================================
+ Hits        10620    10638      +18     
- Misses       7792     7812      +20     
- Partials     1061     1062       +1     
Flag Coverage Δ
e2e 39.70% <ø> (+<0.01%) ⬆️
e2e go 35.72% <ø> (+0.03%) ⬆️
e2e node 30.97% <ø> (+0.04%) ⬆️
e2e python 35.39% <ø> (+0.03%) ⬆️
e2e quarkus 31.12% <ø> (+0.07%) ⬆️
e2e rust 30.57% <ø> (+0.04%) ⬆️
e2e springboot 30.60% <ø> (+0.04%) ⬆️
e2e typescript 31.09% <ø> (+0.04%) ⬆️
integration 17.60% <ø> (-0.06%) ⬇️
unit macos-14 44.46% <ø> (-0.02%) ⬇️
unit macos-latest 44.46% <ø> (-0.02%) ⬇️
unit ubuntu-24.04-arm 44.67% <ø> (+<0.01%) ⬆️
unit ubuntu-latest 45.38% <ø> (-0.02%) ⬇️
unit windows-latest 44.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d304f74 into knative:main Dec 10, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments