Skip to content

Add middleware version in func describe JSON and YAML output#3277

Merged
knative-prow[bot] merged 3 commits intoknative:mainfrom
creydr:add-middleware-version-in-describer
Dec 10, 2025
Merged

Add middleware version in func describe JSON and YAML output#3277
knative-prow[bot] merged 3 commits intoknative:mainfrom
creydr:add-middleware-version-in-describer

Conversation

@creydr
Copy link
Member

@creydr creydr commented Dec 8, 2025

Changes

  • 🎁 Add middleware version in output of func describe -o json|yaml

Additional context: #3270

/kind enhancement

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 8, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.58%. Comparing base (c47c428) to head (fef7ace).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/functions/middleware.go 28.57% 10 Missing and 5 partials ⚠️
pkg/knative/describer.go 62.50% 3 Missing ⚠️
pkg/k8s/describer.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
+ Coverage   54.53%   54.58%   +0.04%     
==========================================
  Files         167      168       +1     
  Lines       19473    19512      +39     
==========================================
+ Hits        10620    10651      +31     
- Misses       7792     7797       +5     
- Partials     1061     1064       +3     
Flag Coverage Δ
e2e 39.69% <37.93%> (-0.01%) ⬇️
e2e go 35.61% <0.00%> (-0.08%) ⬇️
e2e node 30.86% <0.00%> (-0.07%) ⬇️
e2e python 35.37% <0.00%> (+0.01%) ⬆️
e2e quarkus 31.01% <0.00%> (-0.05%) ⬇️
e2e rust 30.44% <0.00%> (-0.08%) ⬇️
e2e springboot 30.49% <0.00%> (-0.07%) ⬇️
e2e typescript 30.97% <0.00%> (-0.07%) ⬇️
integration 17.76% <65.51%> (+0.11%) ⬆️
unit macos-14 44.39% <0.00%> (-0.09%) ⬇️
unit macos-latest 44.39% <0.00%> (-0.09%) ⬇️
unit ubuntu-24.04-arm 44.58% <0.00%> (-0.09%) ⬇️
unit ubuntu-latest 45.31% <0.00%> (-0.09%) ⬇️
unit windows-latest 44.41% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Don't fail on errors receiving the middleware version, e.g. when the image is not available anymore
@creydr creydr changed the title [WIP] Add middleware version in func describe JSON and YAML output Add middleware version in func describe JSON and YAML output Dec 8, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2025
@creydr
Copy link
Member Author

creydr commented Dec 8, 2025

/cc @lkingland @gauron99

@knative-prow knative-prow bot requested review from gauron99 and lkingland December 8, 2025 11:20
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@knative-prow knative-prow bot merged commit 977a20e into knative:main Dec 10, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments