fix: push perm check for gitlab image registry#3263
Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom Dec 1, 2025
Merged
fix: push perm check for gitlab image registry#3263knative-prow[bot] merged 2 commits intoknative:mainfrom
knative-prow[bot] merged 2 commits intoknative:mainfrom
Conversation
For whatever reason the gitlab integrated image registry returns 403 instead of 401 when password is empty. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
+ Coverage 54.52% 54.55% +0.02%
==========================================
Files 162 162
Lines 19216 19219 +3
==========================================
+ Hits 10478 10484 +6
+ Misses 7694 7692 -2
+ Partials 1044 1043 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The CredentialsCallback shall return creds.ErrCredentialsNotFound not nil error if the callback is not appropriate for given registry. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
a1034c7 to
697d086
Compare
Contributor
Author
|
PTAL @lkingland @gauron99 |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fixes #3183
For whatever reason the gitlab integrated image registry returns 403 instead of 401 when password is empty.
/kind bug