Skip to content

cleanup: Builders directory cleanup#3261

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-qstqtummltmv
Dec 2, 2025
Merged

cleanup: Builders directory cleanup#3261
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:push-qstqtummltmv

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Dec 1, 2025

separate the builders into their respective directories buildpacks s2i and oci (already exists) leaving builders for common code.
This PR is also a setup for the new upcoming scaffolding changes

@knative-prow
Copy link

knative-prow bot commented Dec 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.55%. Comparing base (7f7e476) to head (539540b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
+ Coverage   54.52%   54.55%   +0.02%     
==========================================
  Files         162      162              
  Lines       19216    19216              
==========================================
+ Hits        10478    10483       +5     
+ Misses       7694     7689       -5     
  Partials     1044     1044              
Flag Coverage Δ
e2e 39.68% <100.00%> (ø)
e2e go 35.61% <100.00%> (ø)
e2e node 30.98% <100.00%> (ø)
e2e python 35.34% <0.00%> (+0.08%) ⬆️
e2e quarkus 31.14% <100.00%> (ø)
e2e rust 30.58% <100.00%> (+0.01%) ⬆️
e2e springboot 30.61% <100.00%> (ø)
e2e typescript 31.10% <100.00%> (ø)
integration 17.88% <0.00%> (-0.05%) ⬇️
unit macos-14 44.33% <100.00%> (ø)
unit macos-latest 44.33% <100.00%> (ø)
unit ubuntu-24.04-arm 44.51% <100.00%> (-0.02%) ⬇️
unit ubuntu-latest 45.25% <100.00%> (-0.02%) ⬇️
unit windows-latest 44.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 requested review from lkingland and removed request for dsimansk and jrangelramos December 1, 2025 11:50
@gauron99 gauron99 marked this pull request as ready for review December 1, 2025 12:08
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@knative-prow knative-prow bot merged commit e1d4e0f into knative:main Dec 2, 2025
87 of 90 checks passed
@gauron99 gauron99 deleted the push-qstqtummltmv branch December 12, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments