Skip to content

fix(tekton): ensure PAC Repository updates labels and annotations#3258

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
intojhanurag:tekton/pac-repo-labels-annotations-fix
Dec 5, 2025
Merged

fix(tekton): ensure PAC Repository updates labels and annotations#3258
knative-prow[bot] merged 2 commits intoknative:mainfrom
intojhanurag:tekton/pac-repo-labels-annotations-fix

Conversation

@intojhanurag
Copy link
Member

Previously, ensurePACRepositoryExists only compared the Spec of the Repository CR.
This commit updates the function to also compare Labels and Annotations, ensuring
the repository resource is fully synced with the desired state.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2025
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.49%. Comparing base (78f6d41) to head (a79c8dd).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/pipelines/tekton/resources_pac.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
- Coverage   54.52%   54.49%   -0.04%     
==========================================
  Files         162      162              
  Lines       19216    19223       +7     
==========================================
- Hits        10478    10475       -3     
- Misses       7694     7703       +9     
- Partials     1044     1045       +1     
Flag Coverage Δ
e2e 39.66% <0.00%> (-0.03%) ⬇️
e2e go 35.59% <0.00%> (-0.02%) ⬇️
e2e node 30.97% <0.00%> (-0.02%) ⬇️
e2e python 35.23% <0.00%> (-0.02%) ⬇️
e2e quarkus 31.12% <0.00%> (-0.02%) ⬇️
e2e rust 30.56% <0.00%> (-0.02%) ⬇️
e2e springboot 30.59% <0.00%> (-0.02%) ⬇️
e2e typescript 31.08% <0.00%> (-0.02%) ⬇️
integration 17.89% <0.00%> (-0.01%) ⬇️
unit macos-14 44.31% <0.00%> (-0.03%) ⬇️
unit macos-latest 44.31% <0.00%> (-0.03%) ⬇️
unit ubuntu-24.04-arm 44.51% <0.00%> (-0.02%) ⬇️
unit ubuntu-latest 45.24% <0.00%> (-0.03%) ⬇️
unit windows-latest 44.33% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Member Author

Hey @lkingland , Is this good to go?

@intojhanurag
Copy link
Member Author

Hey @gauron99 , Can I get a review on this one.

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@knative-prow knative-prow bot merged commit 7deccdd into knative:main Dec 5, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments