✨ Delete dataservice entities#24
Conversation
|
|
||
| DATASERVICE_URL="http://localhost:5000" | ||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
I know this seems silly for testing delete_entities since this fixture uses the thing we're going to test lol, but we need some way to cleanup the dataservice for all of the integration tests that would make use of the live dataservice. That's also why I added unit tests for delete_entities that make use of mocks and don't depend on the live dataservice.
|
You don't want to just repeatedly call DELETE on the study endpoint until the data service stops erroring? 🤣 |
Lol nooo, that would crash it for the big studies esp the ones that have the cohort VCFs |
d1bee79 to
a78a59c
Compare
| """ | ||
| session = Session() | ||
| errors = {} | ||
| for i, kf_id in enumerate(kfids): |
There was a problem hiding this comment.
It doesn't look like the i from enumerate is being used. Is something missing here?
There was a problem hiding this comment.
Oh i see, oops. One sec
| "participants", | ||
| "family-relationships", | ||
| "families", | ||
| "studies", |
There was a problem hiding this comment.
Just a comment, not part of the change request...
It seems like the 'studies' entry in ENDPOINTS is only used by one test. It might make more sense to put studies into its own constant and not include it here and then add a separate studies endpoint check in that one test so that you don't have to have [:-1] everywhere.
12b7220 to
599327b
Compare
## Release 0.3.0 ### Summary - Emojis: 👷 x2, ✨ x2 - Categories: Additions x2, Ops x2 ### New features and changes - [#25](#25) - 👷 Add release workflow 6a4fe6e - [96e5f65](96e5f65) by [fiendish](https://github.com/fiendish) - [#24](#24) - ✨ Delete dataservice entities - [e48dbbd](e48dbbd) by [znatty22](https://github.com/znatty22) - [#22](#22) - 👷 Add CI config - [82864c0](82864c0) by [fiendish](https://github.com/fiendish) - [#20](#20) - ✨ Add function for reporting S3 and DS GF entries - [f99f2cd](f99f2cd) by [fiendish](https://github.com/fiendish)
## Release 0.3.0 ### Summary - Emojis: 👷 x2, ✨ x2 - Categories: Additions x2, Ops x2 ### New features and changes - [#25](#25) - 👷 Add release workflow - [96e5f65](96e5f65) by [fiendish](https://github.com/fiendish) - [#24](#24) - ✨ Delete dataservice entities - [e48dbbd](e48dbbd) by [znatty22](https://github.com/znatty22) - [#22](#22) - 👷 Add CI config - [82864c0](82864c0) by [fiendish](https://github.com/fiendish) - [#20](#20) - ✨ Add function for reporting S3 and DS GF entries - [f99f2cd](f99f2cd) by [fiendish](https://github.com/fiendish)
Closes #23
Delete entities in Dataservice by study id or blanket delete all entities in Dataservice