Merge development to main 20251202_132133 #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Casual info versioning
Prior to this change, search toggle menu items (regexp, symbol, word) erroneously invoked `isearch-edit-string`, forcing a recursive edit. This created a number of errors, namely: - During recursive edit, the binding to `casual-isearch-tmenu` was not available, blocking a path to change the search mode. - Recursive edit itself is surprising to users not familiar with it. This fix changes to avoid invoking `isearch-edit-string` in the first place. New behavior is to invoke the I-Search toggle command directly. In addition, the `:transient` key is set to `nil`, to return focus back to the I-Search minibuffer prompt. This allows the binding to `casual-isearch-tmenu` to be retained. Descriptions for toggle switches have been changed to use checkboxes for improved usability. Update documentation, including revert of auto-versioning document. This needs to wait for command line generation of the texinfo file. Fix Replace section for read-only behavior.
…avior Fix I-Search Toggle Behavior in `casual-isearch-tmenu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version to 2.11.2-rc.1
Fix Casual info versioning
Fix I-Search Toggle Behavior in
casual-isearch-tmenuPrior to this change, search toggle menu items (regexp, symbol, word)
erroneously invoked
isearch-edit-string, forcing a recursive edit. Thiscreated a number of errors, namely:
casual-isearch-tmenuwas notavailable, blocking a path to change the search mode.
This fix changes to avoid invoking
isearch-edit-stringin the first place.New behavior is to invoke the I-Search toggle command directly. In addition, the
:transientkey is set tonil, to return focus back to the I-Searchminibuffer prompt. This allows the binding to
casual-isearch-tmenuto beretained.
Descriptions for toggle switches have been changed to use checkboxes for
improved usability.
Update documentation, including revert of auto-versioning document. This needs
to wait for command line generation of the texinfo file.
Fix Replace section for read-only behavior.