feat: add Playwright E2E testing infrastructure with tree listing #1674
+273
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8e9951 to
425912a
Compare
676fb72 to
af73aa6
Compare
f93ddf6 to
39e3bf0
Compare
- Add Playwright configuration and test framework - Create e2e tests for tree listing page with proper selectors - Set up strict TypeScript configuration for e2e tests - Add e2e commands to package.json and update scripts - Update .env.example with staging environment as default - Add comprehensive e2e documentation to README - Add Playwright artifacts to .gitignore - Update ESLint and TypeScript configs to support e2e tests - Add vitest config to exclude the e2e folder This establishes a complete E2E testing infrastructure using Playwright with staging as the default test environment, strict TypeScript settings, and proper documentation for developers.
39e3bf0 to
78202a5
Compare
| .first(); | ||
| await expect(intervalInput).toBeVisible(); | ||
|
|
||
| await intervalInput.fill('7'); |
Collaborator
There was a problem hiding this comment.
Since 7 days is the default already, shouldn't we test with a different value?
| const url = page.url(); | ||
| expect(url).toMatch(/\/tree\/[^/]+\/[^/]+\/[^/]+$/); | ||
|
|
||
| await page.goBack(); |
Collaborator
There was a problem hiding this comment.
in this case you're not really using the breadcrumb, just going back like the back arrow in a browser, isn't it?
| const NAVIGATION_TIMEOUT = 5000; | ||
| const GO_BACK_TIMEOUT = 3000; | ||
|
|
||
| test.describe('Tree Listing Page Tests', () => { |
Collaborator
There was a problem hiding this comment.
I think there should be a test for origin change too, can you add it here?
| pnpm test | ||
| ``` | ||
|
|
||
| ## Running end-to-end (e2e) tests |
Collaborator
There was a problem hiding this comment.
after updating the packages (pnpm install) I also had to run pnpm exec playwright install, do you think it's worth it to mention that command here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive Playwright E2E testing infrastructure to the dashboard project. The implementation includes:
Changes
🔧 Framework Setup
playwright.config.tswith environment supporttsconfig.e2e.json🧪 Test Implementation
basic.spec.tstotree-listing.spec.tse2e-selectors.ts) with robust element selectors📋 Configuration & Environment
package.jsonwith singlee2ecommand ande2e-uicommand.env.example🗂️ Git Management
test-results/,playwright-report/) to.gitignoreBenefits
Usage