Conversation
|
🧪 Testing To try out this version of the SDK: Expires at: Fri, 01 May 2026 04:54:11 GMT |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
| func (r *AuthConnectionNewParams) UnmarshalJSON(data []byte) error { | ||
| return json.Unmarshal(data, &r.ManagedAuthCreateRequest) | ||
| return apijson.UnmarshalRoot(data, r) |
There was a problem hiding this comment.
Untagged fields silently ignored during JSON unmarshaling
High Severity
The UnmarshalJSON methods were changed from json.Unmarshal(data, &r.InnerField) to apijson.UnmarshalRoot(data, r), but the inner fields (e.g. ManagedAuthCreateRequest, CreateCredentialRequest, SubmitFieldsRequest, etc.) have no JSON struct tags. The apijson struct decoder explicitly skips fields without JSON tags, so these primary data fields will never be populated during unmarshaling. The MarshalJSON still serializes the inner field's contents directly, making marshal/unmarshal asymmetric — data serialized by MarshalJSON cannot be recovered by UnmarshalJSON.
Additional Locations (2)
Automated Release PR
0.45.1 (2026-04-01)
Full Changelog: v0.45.0...v0.45.1
Bug Fixes
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Note
Low Risk
Small, targeted change to JSON decoding plus a version bump; risk is limited to request param deserialization behavior in the affected endpoints.
Overview
Bumps the SDK version to 0.45.1 (manifest,
internal/version.go, README install snippet) and adds the corresponding CHANGELOG entry.Fixes request parameter unmarshaling for
AuthConnection*Params,Credential*Params, andCredentialProvider*Paramsby replacingencoding/json.Unmarshalinto nested request structs withapijson.UnmarshalRoot(data, r), addressing cases where the previous approach produced incorrect decoding behavior.Written by Cursor Bugbot for commit 61be6d5. This will update automatically on new commits. Configure here.