Open
Conversation
Contributor
Author
|
🧪 Testing To try out this version of the SDK: Expires at: Mon, 27 Apr 2026 04:12:16 GMT |
ab8652e to
13a8c98
Compare
Note that we still want to run tests, as these depend on the metadata.
13a8c98 to
26afb46
Compare
26afb46 to
e2ed144
Compare
e2ed144 to
7eb1834
Compare
7eb1834 to
92fed74
Compare
92fed74 to
a3a0e2b
Compare
a3a0e2b to
9a92786
Compare
9a92786 to
006ddd6
Compare
006ddd6 to
4bdbc19
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| u = parsed.String() | ||
| } else { | ||
| u = u + "?" + params | ||
| } |
There was a problem hiding this comment.
Ignored url.Parse error risks nil pointer dereference
Low Severity
The error from url.Parse(u) is discarded with parsed, _ := url.Parse(u). In Go's standard library, url.Parse returns nil for the *URL when it fails. If u contains control characters or invalid percent-encoding (e.g., %GG), parsed will be nil and the subsequent parsed.RawQuery access will panic with a nil pointer dereference.
4bdbc19 to
625e56e
Compare
625e56e to
ee42d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Automated Release PR
0.45.0 (2026-03-28)
Full Changelog: v0.44.0...v0.45.0
Features
Bug Fixes
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Note
Medium Risk
Medium risk because it changes core request serialization (query param concatenation, multipart encoding, and new
defaulttag behavior) which can affect outbound request shapes across the SDK.Overview
Bumps the SDK release to
0.45.0(manifest, internal version constant, README pin, changelog/spec metadata) and tweaks CI to skip thebuildjob for metadata-onlycodegen metadatacommits.Adds
chrome_policysupport to browser pool create/update/config types (with tests) and introduces adefault:"…"struct tag used by internal JSON and multipart form encoders to emit default string values when fields are zero (also applied to severalevent/regionfields). Multipart form encoding now supports comma-formatted arrays, and URL building avoids producing duplicate?when appending query parameters.Written by Cursor Bugbot for commit ee42d89. This will update automatically on new commits. Configure here.