Conversation
- Added *GasEstimate template. - Added EstimateGas() in ethutil.go
Shadowfiend
approved these changes
Apr 9, 2020
Contributor
Shadowfiend
left a comment
There was a problem hiding this comment.
This looks good to me. Any objections to merging as-is? Looks like threshold-network/keep-core#1550 gave this a good exercising, so we should be good here.
pdyraga
reviewed
Apr 10, 2020
| msg := ethereum.CallMsg{ | ||
| From: from, | ||
| To: &to, | ||
| Data: input, |
Member
There was a problem hiding this comment.
We are not passing Value to CallMsg so the estimation may not be correct for payable functions. I think we need to generate a variation of estimate function just for payable functions.
It's not a top priority because the problem we are having in threshold-network/keep-core#1479 is solved with the code here. I'll open a separate issue to address payable functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs threshold-network/keep-core#1479
In this PR we add the gas estimation functionality. This will be used by Keep applications to retrieve the estimation for a specific transaction.