Skip to content

fix: add missing entry-points to driver packages#331

Merged
raballew merged 5 commits intojumpstarter-dev:mainfrom
raballew:007-fix-driver-list
Mar 18, 2026
Merged

fix: add missing entry-points to driver packages#331
raballew merged 5 commits intojumpstarter-dev:mainfrom
raballew:007-fix-driver-list

Conversation

@raballew
Copy link
Copy Markdown
Member

@raballew raballew commented Mar 17, 2026

Summary

  • Add missing [project.entry-points."jumpstarter.drivers"] sections to 15 driver packages
  • Without these entry-points, jmp driver list cannot discover the drivers via importlib.metadata
  • Affected packages: ble, flashers, http-power, http, iscsi, probe-rs, pyserial, qemu, ridesx, snmp, ssh, tftp, tmt, uboot, ustreamer

Closes #327

Test plan

  • Run jmp driver list and verify all installed drivers appear
  • Verify existing drivers with entry-points are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Registered multiple driver packages for plugin discovery across the Jumpstarter ecosystem (BLE, HTTP, QEMU, SSH, TFTP, ISCSI, and others).
    • Added directory exclusions to git configuration.

raballew and others added 3 commits March 17, 2026 18:31
Resolves jumpstarter-dev#327

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit f8e35d3
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/69ba65cd9ce8f700085e2855
😎 Deploy Preview https://deploy-preview-331--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@raballew has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e1d2426c-f9dc-4354-a769-444975998f53

📥 Commits

Reviewing files that changed from the base of the PR and between 5550991 and f8e35d3.

📒 Files selected for processing (1)
  • .gitignore
📝 Walkthrough

Walkthrough

This PR adds missing entry-point declarations across 16 jumpstarter driver packages to enable driver discovery through the plugin system. Each driver now registers under project.entry-points."jumpstarter.drivers". The .gitignore is also updated with two new ignore patterns.

Changes

Cohort / File(s) Summary
Git Configuration
.gitignore
Added two new ignore patterns: .specify/ and specs/.
Driver Entry-Points Registration
python/packages/jumpstarter-driver-{ble,flashers,http,http-power,iscsi,probe-rs,pyserial,qemu,ridesx,snmp,ssh,tftp,tmt,uboot,ustreamer}/pyproject.toml
Registered driver classes as entry-points under project.entry-points."jumpstarter.drivers" to enable plugin discovery. Each file adds 1–5 entry-point mappings (e.g., BleWriteNotifyStream, TIJ784S4Flasher, QemuFlasher, etc.) pointing to their respective driver implementations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #258: Implements the jmp driver list command that discovers and lists drivers registered via these entry-points.
  • #306: Adds the jumpstarter-driver-probe-rs package implementation that corresponds to the ProbeRs entry-point registered in this PR.
  • #339: Adds the jumpstarter-driver-flashers package with TIJ784S4Flasher and RCarS4Flasher implementations that are registered as entry-points here.

Suggested labels

backport release-0.7

Suggested reviewers

  • NickCao
  • mangelajo
  • bennyz

Poem

🐰 A rabbit hops through driver files,
Registering each with joyful smiles,
Entry-points in pyproject's nest,
Now all drivers will be discovered best!
Hopping forward, the system's blessed! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive The PR includes two minor out-of-scope changes: additions to .gitignore (specs/ and .specify/) and documentation commits that are tangential to the main entry-points fix. Verify whether the .gitignore and documentation changes are necessary for this fix or should be addressed in separate PRs to maintain focused scope.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add missing entry-points to driver packages' directly and clearly summarizes the main change in the PR—adding missing entry-points to 15 driver packages.
Linked Issues check ✅ Passed The PR adds missing entry-points to 15 driver packages to enable driver discovery via importlib.metadata, directly addressing issue #327's requirement that drivers include entry-points for jmp driver list discovery.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raballew raballew marked this pull request as ready for review March 17, 2026 18:53
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but it conflicts, needs conflict/rebase

@raballew raballew merged commit c6cf780 into jumpstarter-dev:main Mar 18, 2026
33 of 34 checks passed
@raballew raballew deleted the 007-fix-driver-list branch March 18, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jmp driver list - not all drivers report themselves

2 participants