Skip to content

ci: run PR workflows on top of any branch#197

Merged
mangelajo merged 1 commit intomainfrom
enable-pr-on-pr-ci
Feb 4, 2026
Merged

ci: run PR workflows on top of any branch#197
mangelajo merged 1 commit intomainfrom
enable-pr-on-pr-ci

Conversation

@mangelajo
Copy link
Copy Markdown
Member

@mangelajo mangelajo commented Feb 4, 2026

This makes sure that PRs depending on ohter PRs are still running all the CI jobs. Otherwise some of the workflows don't run on that type of PR which base is just another branch from another PR.

Summary by CodeRabbit

  • Chores
    • Expanded GitHub Actions workflow triggers to execute on pull requests across all branches instead of main and release-* only, improving test coverage and validation throughout the development process.

This makes sure that PRs depending on ohter PRs are still running
all the CI jobs. Otherwise some of the workflows don't run on that
type of PR which base is just another branch from another PR.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Branch-based filtering removed from pull_request triggers across six GitHub Actions workflows, allowing CI workflows to be triggered by pull requests from any branch instead of only main and release-* branches.

Changes

Cohort / File(s) Summary
Workflow PR Trigger Expansion
.github/workflows/build-images.yaml, .github/workflows/controller-bundle.yaml, .github/workflows/controller-kind.yaml, .github/workflows/controller-tests.yaml, .github/workflows/e2e.yaml, .github/workflows/lint.yaml
Removed branch-based filtering (main and release-*) from pull_request triggers across all workflows. Path-based and other filtering mechanisms remain unchanged; workflows now respond to PRs from any branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • NickCao
  • bennyz

Poem

🐰 Branches once gated, now run free,
Any PR now triggers with glee,
CI gates expanded, tests bloom wide,
From feature branches with pride! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing branch filters from pull request workflows to allow them to run on any branch base.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enable-pr-on-pr-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evakhoni
Copy link
Copy Markdown
Contributor

evakhoni commented Feb 4, 2026

I wonder, why do we even run pytest-matrix and e2e against this PR?

@evakhoni evakhoni self-requested a review February 4, 2026 09:40
@mangelajo
Copy link
Copy Markdown
Member Author

I wonder, why do we even run pytest-matrix and e2e against this PR?

pytest will stop running after we merge the other PR :)

e2e runs because we are modifying - '.github/workflows/e2e.yaml'

@evakhoni
Copy link
Copy Markdown
Contributor

evakhoni commented Feb 4, 2026

e2e runs because we are modifying - '.github/workflows/e2e.yaml'

ah so it's testing changes to it's own ci definitions huh?

pytest will stop running after we merge the other PR :)

ok nice!

Copy link
Copy Markdown
Contributor

@evakhoni evakhoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mangelajo
Copy link
Copy Markdown
Member Author

Thank you :D

@mangelajo mangelajo merged commit d46d76b into main Feb 4, 2026
20 checks passed
@evakhoni evakhoni deleted the enable-pr-on-pr-ci branch February 4, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants