Skip to content

jmp create allows an attepmpt of creating an invalid lease, jmp delete allows deleting an already deleted lease #250

@evakhoni

Description

@evakhoni

if you try to create a lease via jmp shell without passing a selector, it will display the correct error, letting you know that a selector is required.

Error: the lease is invalid: The selector for the lease is empty, a selector is required

if you however create it via jmp create, it will allow creating an invalid one with no selector, which cannot be satisfied, and will provide you with a lease number as if you have a valid lease to use

 jmp create lease --duration 2h 
NAME                                  SELECTOR  BEGIN TIME  DURATION  CLIENT    EXPORTER
019c67cd-3ce1-7efb-8d29-b2cf12afdf9f  <none>                2:00:00   evakhoni      

expecting jmp create to return a similar error to jmp shell in this case.

also, an attempt to delete the lease multiple times, returns a success every time, instead of once

  jmp delete leases 019c67cd-3ce1-7efb-8d29-b2cf12afdf9f
lease "019c67cd-3ce1-7efb-8d29-b2cf12afdf9f" deleted
 ~  jmp delete leases 019c67cd-3ce1-7efb-8d29-b2cf12afdf9f
lease "019c67cd-3ce1-7efb-8d29-b2cf12afdf9f" deleted
 ~  jmp delete leases 019c67cd-3ce1-7efb-8d29-b2cf12afdf9f
lease "019c67cd-3ce1-7efb-8d29-b2cf12afdf9f" deleted
 ~  

expecting some kind of message like "error: lease already deleted" instead.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions