Allow benchmarking with warm parser caches#229
Merged
Conversation
plutonheaven
approved these changes
May 27, 2026
…nto benchmark_with_parser_caching
jtec
commented
May 28, 2026
| df["function"] = df["func"].apply(lambda x: getattr(x, "co_name", None)) | ||
| df["file"] = df["func"].apply(lambda x: getattr(x, "co_filename", None)) | ||
| df = df[df["function"].notnull() & df["file"].str.contains(r"prx[\\/]src[\\/]prx")] | ||
| df = df[df["function"].notnull() & df["file"].str.contains(r"prx/src/prx")] |
Owner
Author
There was a problem hiding this comment.
Don't know where this came from ;)
Collaborator
There was a problem hiding this comment.
It was linked to a path separator issue on Windows vs Linux. It allows the path to contain either '/' or ''. I think we should keep it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an argument to the prx top-level benchmark that makes the benchmark warm up parser caches before profiling run time and memory. Makes the benchmark itself much faster and just as informative, given that the nav and obs file parsers have their own benchmarks we can look at to see how they scale.
Also brings back in-RAM caching for parser caches.
Also removes passing nav file to the benchmark, it will be fetched from IGS anyways if the file name does not follow RINEX 3 conventions.
Example result: