Add a S3 check to healthcheck endpoint#29
Merged
jonathansick merged 1 commit intomainfrom Sep 12, 2023
Merged
Conversation
If the LTD_PROXY_S3_HEALTHCHECK_KEY env variable is enabled, the healthcheck endpoint will attempt to stream that object from the bucket. If it fails, the healthcheck will also fail. This should automatically restart the service in cases where there are danging httpx connections that cause resources leaks and ultimately break the app. This should also give early warning to S3 account/auth issues.
d297b77 to
e98f302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the LTD_PROXY_S3_HEALTHCHECK_KEY env variable is enabled, the healthcheck endpoint will attempt to stream that object from the bucket. If it fails, the healthcheck will also fail.
This should automatically restart the service in cases where there are danging httpx connections that cause resources leaks and ultimately break the app.
This should also give early warning to S3 account/auth issues.