Add support of js-data-sql adapter#328
Merged
jmdobry merged 2 commits intojs-data:masterfrom Apr 15, 2015
Merged
Conversation
Contributor
Author
|
In browserify context, if: There is a bug in adapter registration: In adapter registration loop (https://github.com/js-data/js-data-angular/blob/master/src/index.js#L205-L214), if the first adapter is well registrated, it continue to loop over next adapter when with a wrong object. (I added a commit to current PR, if separate PR is preferable, just tell me) |
Member
|
Wow, I didn't even realize js-sql-adapter would be useful in the browser. And thanks for the fix! |
jmdobry
added a commit
that referenced
this pull request
Apr 15, 2015
Add support of `js-data-sql` adapter
Contributor
Author
|
@jmdobry Yeah. I thought I was crazy to dig into it but it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-data-sqlworks really great browser-side. I use it for manipulate a WebSql database and it works like a charm !js-datais pretty amazing!