Skip to content

Bump dependencies#34

Merged
mkristian merged 7 commits intojruby:masterfrom
deivid-rodriguez:bump_versions
Nov 3, 2021
Merged

Bump dependencies#34
mkristian merged 7 commits intojruby:masterfrom
deivid-rodriguez:bump_versions

Conversation

@deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Nov 2, 2021

We should get a release out that uses more modern dependencies that actually work on jruby 9.2.

This would be needed for jruby/ruby-maven#4.

@deivid-rodriguez
Bump jruby plugins to 2.0.1
4301e09
@deivid-rodriguez
Bump mavengem-wagon to 1.0.3
683b1c9
@deivid-rodriguez
Don't use maven-tools for this repo itself
f98274c 
Otherwise if `maven-tools` has an issue like now, we can't fix it
because we need the fixed library itself to fix it, so... chicken and
egg issue.
@deivid-rodriguez
Use version 2.0.1 of jruby plugins
8f8b6e4
@deivid-rodriguez
Don't test head versions
a115ff6 
Since we can barely support released versions.
@deivid-rodriguez
Update tested rubies and javas to something more current
59d2043
This was referenced Nov 2, 2021
Merged
Merged
@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Nov 2, 2021

I verified that CI is green on my fork: https://github.com/deivid-rodriguez/maven-tools/actions/runs/1413239353.

@mkristian Thoughts on this?

mkristian
mkristian approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@mkristian mkristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Nov 2, 2021

Great!

Note that I removed Mavenfile and .mvn/extensions.yml in favor of a plain pom.xml file, because I was trying to build my changes, but the problem I'm trying to fix here would prevent me from doing it, because maven-tools 1.1.6 was being pulled through the polyglot-ruby dependency. So to fix it, I opted out of polyglot-ruby in this repo.

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Nov 2, 2021 •
edited
Loading

I don't want to abuse your amazing responsiveness, but if we can get this released, I think we will have mostly fixed this chain of dependency issues 😃.

@mkristian
Copy link
Member

mkristian commented Nov 3, 2021

@deivid-rodriguez my understanding is that polyglot-ruby is using this gem as well.

@mkristian mkristian merged commit bc95a18 into jruby:master Nov 3, 2021
@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Nov 3, 2021

Yes, exactly, next step would be to bump polyglot-ruby's dependency on this gem after this PR is released. See takari/polyglot-maven#236.

@deivid-rodriguez deivid-rodriguez deleted the bump_versions branch November 3, 2021 14:24
@mkristian
Copy link
Member

mkristian commented Nov 3, 2021

@deivid-rodriguez let me see how to push this rubygems.org - didn't do it for some time.

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Nov 3, 2021

Great, if you need help, let me know!

@headius headius added this to the pre-1.2.0 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkristian mkristian mkristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

pre-1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@deivid-rodriguez @mkristian @headius