Fix for CRL verify when signed with EC key#276
Merged
kares merged 2 commits intojruby:masterfrom May 3, 2023
Merged
Conversation
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Contributor
Author
|
I've added a test case, but it depends on some hardcoded test data. I did not see a script that I could adjust, so it is manually generated. I set expiration for 50 years, so that expiration of test data should not become a failure reason for this test. |
Member
|
Great work, Thanks Tero |
tsaarni
added a commit
to Nordix/jruby-openssl
that referenced
this pull request
May 23, 2023
* Fix for CRL verify when signed with EC key Signed-off-by: Tero Saarni <tero.saarni@est.tech> * Added test case for CRL validation Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Contributor
Author
|
Hi @kares, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for verifying the signature CRL files that are signed using EC private key.
It allows using CRL files that are issued by CA that uses EC key pair. Previously the CRL check failed, and peer certificate was always rejected as invalid even if it was valid, since the validation of CRL file itself failed.
Fixes #275