Conversation
9244386 to
1329c53
Compare
|
Still a WIP since I want to work on some stuff that I skipped when I shouldn't, but I have a green baseline now supportting jruby 9.2 and java 11: https://github.com/deivid-rodriguez/jruby-maven-plugins/actions/runs/964460637. |
It makes it much easier to troubleshoot errors.
Wrapper generated through `mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.3`.
f399afa to
09dcb1d
Compare
9fc9185 to
5685229
Compare
|
Hei @mkristian, I see that you pushed some of the patches that used to live in this WIP PR to master and released 2.0.0. I was just trying things and wasn't really expecting anything to be merged as it was, but I'm glad things are moving forward. Anyways, I was working on fixing CI for jruby/ruby-maven#4, since we need it (or at least it'd be desirable) to be able to release a new version. However, we're running into a rubygems errors due to So I head over polyglot-ruby to get the version of That made me realize that Can you review this and let me know if it makes sense to you? |
|
Awesome @mkristian, thanks so much! Looking forward for a new release including this 💪. |
|
let me release this today . . . |
CI is running into an error readingUsing a newer jruby seems to fix it.EDIT: I'm reusing this PR with a different intention from the original one. Some commits present in the original version of this PR (which intended to add Java 11 support) were introduced directly to the master branch, and some of them broke Java 8 support. This PR now restores Java 8 support, and also brings the additional changes resulting from rebasing the original changes against the new master branch.