Don't return too long company ids. Fix for #1233 - #1237
Merged
Conversation
* Handle invalid checksum 1 * Add tests for checksum length
Collaborator
|
Thank you! ✨ |
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* Handle invalid checksum 1 * Add tests for checksum length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this changes
This is a bugfix for #1233 .
What was wrong
Finnish company id calculation did not handle invalid remainder 1 in checksum calculation, resulting two digit checksums.
How this fixes it
Company id is generated until a valid one is found