refactor(css): WP1 / Phase 1 complete — tokens defined+rolled out, orphan cleanup, nav race fix#360
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (90)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…, option c) page/header.html renders header-content.html via partialCached with no variant key, so navigation.html's per-page $active computation was frozen from whichever page rendered first — in practice no menu item was ever highlighted on the live site, and one sprint-5 build nondeterministically marked Blog active on all 1300 pages (screenshot-flake source). This codifies the de-facto behavior: active computation removed from the template, the two dead .-active rules removed from navigation.css. Alternative (make active-state actually work): key the cache by computed active-menu id (9 entries) — documented in the tracker if wanted later. Gate: converged production build — css bundles identical; all 780 pages carrying the inline nav bundle diff by exactly the two removed dead rules (verified per page), computed styles unchanged (no element ever has -active). test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…omponent partials content/_test/use-case-cards-test.md (draft: true, never built), layouts/_test/single.html (sole consumer of the _test type), and the three partials only it called: components/hero-section.html, use-case-card.html, testimonial.html. Verified: live pages use page/testimonials.html and img/testimonial.html, never these; zero callers outside _test repo-wide. NOTE: component-bundle.css stays — verification found it live (blog-list + free-consultation bundles), correcting the sprint-5 assumption. Gate: converged production build byte-identical (bundles, inline styles, zero non-noise HTML diffs). test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
accessibility-focus.css, bem-404-conversion.css, bem-home-page-minimal.css, cta-backgrounds.css, fl-foundation.css, mobile-fixes.css — zero resources.Get loaders and zero @imports (no resources.Match globs exist in the theme, so loader counts are exhaustive); remaining refs are prose comments noting rules were moved out. bem-home-page-minimal.css carried the dead --cta-button-bg token, dissolving that sprint-4 repoint follow-up. Gate: converged production build byte-identical. test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nding) partials/data/authors-cached.html, testimonials-cached.html, company-cached.html — zero callers repo-wide (live page/testimonials.html uses an image partial, not these; no dynamic printf partial names exist in the theme). Gate: converged production build byte-identical. test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
751032a to
06087bd
Compare
…lector grouping services-critical.css carried 6 per-fl-node copies of the same infobox rule set (3 full + 3 without the more-link rules), identical modulo node id. Grouped selectors at the first block's position, rule order preserved; -224 source lines. Compiled output byte-identical — cssnano already merged the duplicates, so this is source hygiene (the WP's projected 1.5KB output saving was already realized by the pipeline). Gate: per-node rule expansion of the services inline CSS identical to baseline; only page inlining these nodes is services/index.html. test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ss audit
Components never imported by any live bundle: buttons-migration.css,
c-navigation.css, c-gravity-forms.css, navigation-migration.css.
Dead aggregator utilities/_consolidated-utilities.css + its 12-file
orphan closure (c-spacing, display, flexbox, margins, padding, position,
fl-builder-basic, grid/fl-col, positioning/center-absolute,
responsive/{breakpoints,visibility}) — sole importer was the aggregator,
which itself @imports a nonexistent grid/fl-row.css, proving it never
compiles. Notable: this closure IS WP1.2's 'reset utilities' — extracted
in an earlier era, wired to nothing, classes in no template.
Settles --color-secondary as obsolete: its only consumers were in dead
buttons-migration.css. Kept fl-builder-visibility.css (live importers).
Gate: converged production build byte-identical (bundles + inline styles).
test:critical 46/46, dtest 46/46.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…wire foundation + spacing tokens 15 literals across c-button, c-social-share, content-block (components inline bundle) and c-pp-advanced-menu (component-bundle). Foundation now @imported at the top of components.css — NOT prepended via the baseof resource slice: that puts :root before the file's @imports, which CSS invalidates, and silently emptied the whole components bundle (caught by the swap gate; rules 88→70 + vanished style block). --spacing-sm: 0.75rem / --spacing-md: 1rem defined at the values content-block.css fallbacks already resolve to (rendering-neutral); the dead 0.5rem c-spacing.css family was deleted earlier this sprint. Gate: symmetric swap gate PASS (all bundles + 12 pages' inline blocks rule-identical under var↔literal normalization). test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…across 50 files The token had consumers for years but NO definition — 28 fallback-less declarations shipped invalid-at-computed-value (audited rule by rule). The six LIVE broken groups (blog-list + free-consultation bundles) were codified to their shipped rendering FIRST (inherit for color, transparent/currentColor for the non-inherited props — exactly what invalid var() computes), so defining the token changes zero pixels. Purged-in-output consumers keep var() and become valid-and-inert. All #1a8cff/#1A8CFF literals swapped to var(--color-primary) in one atomic commit (dedup-twin rule). Gate findings, all computed-proven equivalent via viewport-fingerprint (last-wins per selector/property at 500/861/1024/1115/1200px): careers/clients border shorthand→longhand expansion (cssnano), single-career/single-use-cases dedup-twin rule re-splits with identical values; the only fingerprint delta is the new :root definition itself. test:critical 46/46, dtest 46/46. Also removes the stale css-variables.css comment claiming --color-primary 'already exists' — the audit proved it never did. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ault (4px) ~168 muted-gray literals and 137 exact border-radius:4px declarations (incl. -moz/-webkit prefixed) swapped to tokens across live CSS, atomic per the dedup-twin rule. --color-muted fulfils the WP1.1 '--color-text' item (body text is --color-dark; this is the secondary/muted voice). --color-secondary NOT defined — audit proved its only consumers lived in the deleted orphan buttons-migration.css. KEEP LITERAL: the reboot-generic button radius triplets in 8 critical files (tokenizing breaks dedup-twin byte-identity; the deleted duplicate re-appeared in all 13 page bundles until reverted). Gate: symmetric swap gate clean except one cssnano merge-product change in free-consultation (button radius merged into an adjacent rule) — viewport-fingerprint proves computed-equivalence at 5 widths; only delta is the new :root defs. test:critical 46/46, dtest 46/46. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…WP1.4 measured net-negative Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sprint 6 of Project 2509, now covering the full WP1 / Phase 1 closure. 11 commits, zero visual regressions, every commit gated (symmetric swap gate + viewport-fingerprint computed-equivalence +
test:critical46/46 +dtest46/46).Phase 1 outcome
--color-primary,--color-muted,--radius-default,--spacing-sm/mddefined + ~590 literals tokenized;--color-secondaryobsolete (only consumers were dead files)Key findings
--color-primarywas never defined: 28 fallback-lessvar(--color-primary)declarations shipped invalid-at-computed-value for years. The six live rule groups were codified to their shipped rendering (inherit/transparent/currentColor) before defining the token, so zero pixels changed; the rest are purge-stripped.-activemenu state never worked (header cached viapartialCachedwith no variant key) — removed per analyst option (c); option (b) to make it actually work is documented in the tracker._testapparatus + partials, orphan components,_consolidated-utilitiesclosure).:rootbefore a file's@imports and silently empties the bundle — wire foundations as@importat the top of the entry file.Verification method (per commit)
Converged production build vs converged baseline; symmetric rule-level swap gate (var↔literal normalized both sides, all
:rootdefs stripped, inline bundles extracted from HTML); viewport-fingerprint (last-wins per selector/property at 500/861/1024/1115/1200px) wherever bytes moved; both visual suites. KEEP LITERAL applied where tokenization provably changes merge products (reboot button radius triplets).🤖 Generated with Claude Code