-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ui): Fix 404 page assets, footer icons, client logos, and revert dark theme #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a0caadd
fix(ui): Update typography to Obsidian Ruby design system
pftg a662b8a
fix(ui): use absolute URLs for assets to fix 404 page rendering
pftg 34f9c8a
fix(ui): mobile hero order and client logo grid
pftg 51fcb75
test: update screenshot baselines after UI fixes
pftg a03ea25
revert: remove Obsidian Ruby dark theme typography
pftg 826c1bf
test: update screenshot baselines after typography revert
pftg 346bc3a
revert: remove mobile hero reorder to preserve original layout
pftg 803798d
test: updates scrns
pftg 64655e0
fix: address CodeRabbit review comments
pftg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-185 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/about_page/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+28 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/about_page/_missions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+57.9 KB
(190%)
test/fixtures/screenshots/linux/desktop/blog/index/_pagination.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-185 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/careers/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/careers/junior-ruby-on-rails-developer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-179 Bytes
(100%)
...es/screenshots/linux/desktop/careers/junior-ruby-on-rails-developer/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-168 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/clients/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
test/fixtures/screenshots/linux/desktop/clients/_real-clients.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-169 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/clients/agent-inbox/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/clients/agent-inbox/_overview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-432 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/free_consultation.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/homepage/_clients.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-169 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/homepage/_footer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.37 KB
(100%)
test/fixtures/screenshots/linux/desktop/homepage/_services.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/homepage/_technologies.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-168 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/_footer.png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/_overview.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/app_web_development.png
Oops, something went wrong.
Binary file modified
BIN
-52 Bytes
(100%)
...res/screenshots/linux/desktop/services/fractional-cto/_clients-case-studies.png
Oops, something went wrong.
Binary file modified
BIN
-175 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/fractional-cto/_footer.png
Oops, something went wrong.
Binary file modified
BIN
+104 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/fractional-cto/_overview.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/services/fractional_cto.png
Oops, something went wrong.
Binary file modified
BIN
-168 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/use-cases/_footer.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
test/fixtures/screenshots/linux/desktop/use-cases/_overview.png
Oops, something went wrong.
Binary file modified
BIN
-174 Bytes
(100%)
...enshots/linux/desktop/use-cases/startup-mvp-prototyping-development/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
test/fixtures/screenshots/linux/mobile/about_page/achievements.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
test/fixtures/screenshots/linux/mobile/about_page/values.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-118 Bytes
(100%)
test/fixtures/screenshots/linux/mobile/blog/index/_pagination.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-3 Bytes
(100%)
test/fixtures/screenshots/linux/mobile/free_consultation.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+7.38 KB
(160%)
test/fixtures/screenshots/linux/mobile/nav/hamburger_menu.png
Oops, something went wrong.
Binary file modified
BIN
-197 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/about_page/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-170 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/careers/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-166 Bytes
(100%)
...es/screenshots/macos/desktop/careers/junior-ruby-on-rails-developer/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-175 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/clients/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-184 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/clients/agent-inbox/_footer.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/homepage/_clients.png
Oops, something went wrong.
Binary file modified
BIN
+35 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/homepage/_cta-contact_us.png
Oops, something went wrong.
Binary file modified
BIN
-156 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/homepage/_footer.png
Oops, something went wrong.
Binary file modified
BIN
+22 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/homepage/_technologies.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-184 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/services/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-23 Bytes
(100%)
...res/screenshots/macos/desktop/services/fractional-cto/_clients-case-studies.png
Oops, something went wrong.
Binary file modified
BIN
-191 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/services/fractional-cto/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-187 Bytes
(100%)
test/fixtures/screenshots/macos/desktop/use-cases/_footer.png
Oops, something went wrong.
Binary file modified
BIN
-190 Bytes
(100%)
...enshots/macos/desktop/use-cases/startup-mvp-prototyping-development/_footer.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| /* Homepage semantic hooks migration layer. | ||
| * Intentionally starts empty to keep behavior identical. | ||
| * Future section-level styles should target .jt-home-* classes here. | ||
| */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <link rel="apple-touch-icon" sizes="180x180" href="{{ (resources.Get "img/favicon/apple-touch-icon.png" | fingerprint "md5").RelPermalink }}"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="{{ (resources.Get "img/favicon/favicon-32x32.png" | fingerprint "md5").RelPermalink }}"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="{{ (resources.Get "img/favicon/favicon-16x16.png" | fingerprint "md5").RelPermalink }}"> | ||
| <link rel="manifest" href="{{ (resources.Get "img/favicon/site.webmanifest" | resources.ExecuteAsTemplate "site.webmanifest" . | fingerprint "md5").RelPermalink }}"> | ||
| <link rel="mask-icon" href="{{ (resources.Get "img/favicon/safari-pinned-tab.svg" | fingerprint "md5").RelPermalink }}" color="#5bbad5"> | ||
| <link rel="apple-touch-icon" sizes="180x180" href="{{ (resources.Get "img/favicon/apple-touch-icon.png" | fingerprint "md5").Permalink }}"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="{{ (resources.Get "img/favicon/favicon-32x32.png" | fingerprint "md5").Permalink }}"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="{{ (resources.Get "img/favicon/favicon-16x16.png" | fingerprint "md5").Permalink }}"> | ||
| <link rel="manifest" href="{{ (resources.Get "img/favicon/site.webmanifest" | resources.ExecuteAsTemplate "site.webmanifest" . | fingerprint "md5").Permalink }}"> | ||
| <link rel="mask-icon" href="{{ (resources.Get "img/favicon/safari-pinned-tab.svg" | fingerprint "md5").Permalink }}" color="#5bbad5"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.