Skip to content

replace absUrl with relUrl #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pftg merged 2 commits into from
Oct 23, 2024
Merged

replace absUrl with relUrl #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1c42f
replace absUrl with relUrl
AucT Oct 23, 2024
9cf1c1e
Update themes/beaver/layouts/404.html
pftg Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions themes/beaver/layouts/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ <h1 class="fl-heading">
<div class="fl-module fl-module-button fl-node-ar7hkgve10jq" data-node="ar7hkgve10jq">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-left">
<a href="{{ absURL "" }}" target="_self" class="fl-button">
<a href="{{ relURL "" }}" target="_self" class="fl-button">
<span class="fl-button-text">Back to Homepage</span>
</a>
</div>
Expand Down Expand Up @@ -107,7 +107,7 @@ <h2 class="fl-heading">
<div class="fl-module fl-module-button fl-node-fxvw9yp0o6l7" data-node="fxvw9yp0o6l7">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-center">
<a href="{{ absURL " free-consultation/" }}" target="_self"
<a href="{{ relURL "free-consultation/" }}" target="_self"
class="fl-button">
<span class="fl-button-text">Talk to an Expert</span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion themes/beaver/layouts/page/careers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ <h1 class="fl-heading">
<div class="fl-module fl-module-button fl-node-4sahmupye5n9" data-node="4sahmupye5n9">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-left">
<a href="{{ absURL "contact-us/" }}" target="_self" class="fl-button">
<a href="{{ relURL "contact-us/" }}" target="_self" class="fl-button">
<span class="fl-button-text">Get in Touch</span>
</a>
</div>
Expand Down
44 changes: 22 additions & 22 deletions themes/beaver/layouts/page/index.html
View file
Open in desktop

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions themes/beaver/layouts/page/services.html
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions themes/beaver/layouts/page/use-cases.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ <h3>Startup MVP Prototyping &amp; Development</h3>

We’ve helped startups across a variety of industries go from zero to go-to-market at a fraction of the costs with prototyping &amp; MVP development services.</li>
</ul>
<p><a title="Startup MVP Prototyping &amp; Development" href="{{ absURL "use-cases/startup-mvp-prototyping-development/" }}">Learn More</a></p>
<p><a title="Startup MVP Prototyping &amp; Development" href="{{ relURL "use-cases/startup-mvp-prototyping-development/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down Expand Up @@ -160,7 +160,7 @@ <h3>Salvage an Existing Project</h3>
</svg>
We can help transform the long-term stability of your software product, providing the visibility, clarity, and control you need to get your project on track.</li>
</ul>
<p><a title="Salvage an Existing Project" href="{{ absURL "use-cases/salvage-existing-project/" }}">Learn More</a></p>
<p><a title="Salvage an Existing Project" href="{{ relURL "use-cases/salvage-existing-project/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down Expand Up @@ -202,7 +202,7 @@ <h3>Emergency CTO Leadership</h3>
</svg>
With access to a fractional CTO, you can maintain best practices, hire developers faster, &amp; streamline operations at a fraction of the cost of a full-time CTO</li>
</ul>
<p><a title="Emergency CTO Leadership" href="{{ absURL "use-cases/emergency-cto-leadership/" }}">Learn More</a></p>
<p><a title="Emergency CTO Leadership" href="{{ relURL "use-cases/emergency-cto-leadership/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down Expand Up @@ -244,7 +244,7 @@ <h3>Empower an Existing Engineering Team</h3>
</svg>
With access to on-demand engineering resources, you can help support your core team and make it easier for them to adapt as the environment changes.</li>
</ul>
<p><a title="Empower an Existing Engineering Team" href="{{ absURL "use-cases/empower-existing-engineering-team/" }}">Learn More</a></p>
<p><a title="Empower an Existing Engineering Team" href="{{ relURL "use-cases/empower-existing-engineering-team/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down Expand Up @@ -286,7 +286,7 @@ <h3>Accelerate Development &amp; Maximize Capacity</h3>
</svg>
With access to on-demand engineering resources, you can accelerate development speed while maintaining product quality.</li>
</ul>
<p><a title="Accelerate Development &amp; Maximize Capacity" href="{{ absURL "use-cases/accelerate-development-maximize-capacity/" }}">Learn More</a></p>
<p><a title="Accelerate Development &amp; Maximize Capacity" href="{{ relURL "use-cases/accelerate-development-maximize-capacity/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down Expand Up @@ -328,7 +328,7 @@ <h3>Automate Product QA &amp; Testing</h3>
</svg>
With our fully-managed software testing &amp; QA services, you can accelerate development cycles while minimizing costly mistakes &amp; product errors.</li>
</ul>
<p><a title="Automate Product QA &amp; Testing" href="{{ absURL "use-cases/automate-product-qa-testing/" }}">Learn More</a></p>
<p><a title="Automate Product QA &amp; Testing" href="{{ relURL "use-cases/automate-product-qa-testing/" }}">Learn More</a></p>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion themes/beaver/layouts/partials/page/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ <h5 class="fl-heading">
<div class="fl-module-content fl-node-content">
<div class="fl-rich-text">
<ul>
<li><a href="{{ absURL "privacy-policy/" }}">Privacy Policy</a></li>
<li><a href="{{ relURL "privacy-policy/" }}">Privacy Policy</a></li>
</ul>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion themes/beaver/layouts/partials/page/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<header class="top-panel">
<div class="wrapper">
<div class="content">
<a href="{{ absURL "/" }}" target="_self" itemprop="url" class="logo" title="JetThoughts">
<a href="{{ relURL "/" }}" target="_self" itemprop="url" class="logo" title="JetThoughts">
{{ partial "svg" "logo-dark" }}
</a>

Expand Down
4 changes: 2 additions & 2 deletions themes/beaver/layouts/services/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ <h1 class="fl-heading">
<div class="fl-module fl-module-button fl-node-yen21dfv4kag" data-node="yen21dfv4kag">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-left">
<a href="{{ absURL "free-consultation/" }}" target="_self" class="fl-button">
<a href="{{ relURL "free-consultation/" }}" target="_self" class="fl-button">
<span class="fl-button-text">Talk to an Expert</span>
</a>
Comment on lines +49 to 51

@coderabbitai coderabbitai Bot Oct 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the results, I can now generate the final response as we have clear evidence of inconsistencies in URL handling across the theme.

URL handling inconsistencies found in theme templates

Several issues need attention:

  • absURL is still being used in partials/page/footer.html with empty strings
  • Multiple templates contain hardcoded URLs to /contact-us/ instead of using relURL
  • Blog tag links in multiple templates use hardcoded paths instead of relURL

Locations requiring updates:

  • themes/beaver/layouts/partials/page/footer.html: Replace absURL "" with appropriate relURL usage
  • Contact button URLs in multiple templates:
    • use-cases/single.html
    • clients/single.html
    • page/services.html
    • page/index.html
    • services/single.html
    • page/use-cases.html
    • page/about.html
    • page/clients.html
  • Blog tag links in:
    • blog/list.html
    • _default/single.html
    • _default/list.html
🔗 Analysis chain

Verify consistent URL generation across theme

Let's verify that all template files in the theme use relURL consistently.

Also applies to: 216-218

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining instances of absURL in theme templates
# and identify other hardcoded URLs that might need updating

echo "Checking for remaining absURL usage in theme templates..."
rg --type html 'absURL' themes/beaver/layouts/

echo "Checking for potentially hardcoded URLs in theme templates..."
rg --type html 'href="https://github.com/' themes/beaver/layouts/

Length of output: 2468

</div>
Expand Down Expand Up @@ -213,7 +213,7 @@ <h2 class="fl-heading">
<div class="fl-module fl-module-button fl-node-v5trdupqjywo" data-node="v5trdupqjywo">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-right">
<a href="{{ absURL "clients/" }}" target="_self" class="fl-button">
<a href="{{ relURL "clients/" }}" target="_self" class="fl-button">
<span class="fl-button-text">View All Clients</span>
</a>
</div>
Expand Down
4 changes: 2 additions & 2 deletions themes/beaver/layouts/use-cases/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h1 class="fl-heading">
<div class="fl-module fl-module-button fl-node-wh4cbm261s3z" data-node="wh4cbm261s3z">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-left">
<a href="{{ absURL "free-consultation/" }}" target="_self" class="fl-button">
<a href="{{ relURL "free-consultation/" }}" target="_self" class="fl-button">
<span class="fl-button-text">Talk to an Expert</span>
</a>
</div>
Expand Down Expand Up @@ -184,7 +184,7 @@ <h2 class="fl-heading">
<div class="fl-module fl-module-button fl-node-qym512pwze3d" data-node="qym512pwze3d">
<div class="fl-module-content fl-node-content">
<div class="fl-button-wrap fl-button-width-auto fl-button-right">
<a href="{{ absURL "clients/" }}" target="_self" class="fl-button">
<a href="{{ relURL "clients/" }}" target="_self" class="fl-button">
<span class="fl-button-text">View All Clients</span>
</a>
</div>
Expand Down