Some enhancements #52
Merged
+60
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Do you really need to keep it public? If yes, Javadoc is required
Member
Author
There was a problem hiding this comment.
Commit description says "Move to separate method to have ability re-register hooks" from groovy for example.
Member
There was a problem hiding this comment.
Yes, My bad. I've finally bothered to read the PR
Member
|
What about creating a Unit test for the new method? |
Member
Author
|
I have no time and no idea ;) i just split method. And this button will be used only by few people that hit folders bug. |
Member
Author
|
rebased, force-pushed |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Member
Author
|
User confirmed that it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.