Skip to content

Conversation

@dbsanfte
Copy link

@dbsanfte dbsanfte commented Nov 21, 2017

Support for ignoring push events from certain Github usernames. The obvious use case is ignoring push events from a Jenkins user and keeping them from re-triggering builds.

Tests + help files.


This change is Reviewable

@KostyaSha
Copy link
Member

And that wouldn't work like you expect, triggering decision should be in trigger and not in incoming hooks. Either you will get in any case build for this user from trigger run.

@lanwen
Copy link
Member

lanwen commented Nov 27, 2017

This is not a global story. All decisions should be delegated to job level

@dbsanfte
Copy link
Author

dbsanfte commented Nov 29, 2017

Happy to make changes, but for a feature that should have been in the plugin from the get-go, beggars shouldn't be so choosy.

Is it possible to delegate this to the trigger without there being a "failed build" in Jenkins? That's what the [ci skip] plugin results in. Events from ignored users shouldn't be recognized at all.

@KostyaSha
Copy link
Member

KostyaSha commented Nov 29, 2017

Triggers has possibility to re-run checks, so any filtering on event processing will be ignored and you will get all builds. Filtering events is broken by design or may help only for pure triggers. But it wouldn't really help even for github push hooks trigger existing here because git polling will anyway find something different.

Use advanced triggers that could handle everything correctly. Also github user is weird criteria, it doesn't exist after event gone. You should use git commit message/author filtering, not gh user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants