Skip to content

Add option to change homepage #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mertkahyaoglu merged 3 commits into from
Dec 6, 2020
Merged

Add option to change homepage #617

mertkahyaoglu merged 3 commits into from
Dec 6, 2020

Conversation

@mertkahyaoglu
Copy link
Member

@mertkahyaoglu mertkahyaoglu commented Dec 4, 2020

Closes #156

@mertkahyaoglu mertkahyaoglu self-assigned this Dec 4, 2020
@mertkahyaoglu mertkahyaoglu mentioned this pull request Dec 4, 2020
Closed
@mertkahyaoglu mertkahyaoglu requested a review from lexoyo December 4, 2020 19:26
@ashmaroli
Copy link
Member

ashmaroli commented Dec 6, 2020

What if the user would like to have the data or drafts route as their homepage?

@mertkahyaoglu
Copy link
Member Author

mertkahyaoglu commented Dec 6, 2020

@ashmaroli I didn't think anybody would want that 😅 We can add that but do you think that's a useful case?

@ashmaroli
Copy link
Member

ashmaroli commented Dec 6, 2020

Since users are asking for the homepage to be something other the /pages/ route, I think it'd be best if user could choose whatever supported route to be their indexRoute..

@mertkahyaoglu
Copy link
Member Author

mertkahyaoglu commented Dec 6, 2020

@ashmaroli 👍 Added all other routes as well.

@ashmaroli
Copy link
Member

ashmaroli commented Dec 6, 2020

The implementation LGTM!
Does this need test coverage?

@mertkahyaoglu
Copy link
Member Author

mertkahyaoglu commented Dec 6, 2020

Absolutely but it's a bit tricky to test so I skipped it thinking code is safe. We'll see if we get any issue about this 😅

@mertkahyaoglu mertkahyaoglu merged commit 3580e32 into master Dec 6, 2020
@mertkahyaoglu mertkahyaoglu deleted the default-page branch December 6, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@lexoyo lexoyo Awaiting requested review from lexoyo

Assignees

@mertkahyaoglu mertkahyaoglu

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dashboard main page, rather than being welcomed by posts or pages

3 participants

@mertkahyaoglu @ashmaroli