Add CreateMarkdownPage component #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertkahyaoglu
approved these changes
Dec 17, 2019
Member
mertkahyaoglu
left a comment
There was a problem hiding this comment.
PRs like this really satisfy me 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To contain repeated
renderlogic inDraftNew.js,DocumentNew.js,PageNew.js.However, this leaves the parent components as just shells that handle saving the draft and their own respective lifecycle methods which cannot be tested with just a
shallowrender.(
mountis currently not possible since there isn't a mechanism to pass a mock-store to theMetafieldsnested inside theCreateMarkdownPagecomponent.)