Optimize API Hash objects #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API_SCAFFOLD is the base hash with each key pointing to a `nil` value.
When merged with the API generated via calling `#hash_for_api`, the
values of the base API will get updated. Therefore, the first two keys
of the final api hash from calling `#to_api` will always be "name" and
"path".
The url fields ("http_url", "api_url", and collections' "entries_url")
are injected towards the end so that they are always the last keys of
the api hash.
mertkahyaoglu
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API_SCAFFOLDis the base hash with each key pointing to anilvalue. When merged with the API generated via calling#hash_for_api, the values of the base API will get updated. Therefore, the first two keys of the final api hash from calling#to_apiwill always be "name" and "path".The url fields ("http_url", "api_url", and collections' "entries_url") are injected towards the end so that they are always the last keys of the api hash.
Hash#merge!for subsequent merges to avoid generating a new Hash object unnecessarily.