Tab close button, vertical alignment

[ncelerier]

Hello,

This has been tested with a clean install of Eclipse and Jeeeyul's Themes.

Environment:

Windows 7, Eclipse 4.3.2, Jeeeyul's Themes 2.1.4 (happens after the update to 2.1.6 too)

The problem:

Tab close button is not aligned with text baseline : it is 1px above it. I think it would look cleaner if the close button was aligned with text baseline (remove 1px) or 1px below it (remove 2px).

Image part 1 : to see the numbers of pixels as it is now ;
Image part 2 : as it is now
Image part 3 : proposal (remove 1px)
Image part 4 : proposal (remove 2px)

What do you think about it ?

Thank you !

[jeeeyul]

What if user want to use bigger font than 16px, this idea will not be seen beautiful. Just center aligning is more general to me.

Currently there is no GUI to customize font or size(should be added later), However user can easily change it with custom css:

.MPartStack > CTabItem {
    font-size: 30px;
}
.MPartStack {
    swt-tab-height: 36px;
}

Jeeeyul's Eclipse Themes is not just only theme set.
It is additional CSS capability provider, CTabFolderRenderer API Provider and Customize UI Provider, So I should be more cautious to let the result with any settings be elegant.

I think we may need property likes close-button-vertical-alignment seems like:

jtab-close-button-vertical-alignment: center;
jtab-close-button-vertical-alignment: top;
jtab-close-button-vertical-alignment: bottom;
jtab-close-button-vertical-alignment: baseline;
jtab-close-button-vertical-alignment: 4px;

[ncelerier]

Indeed, it might be a problem. I think it would be best indeed if the user had the possibility to define himself what kind of vertical alignment he wants.