kernel_netlink: Allow to run inside non-privileged docker container#23
Closed
christf wants to merge 2 commits into
Closed
kernel_netlink: Allow to run inside non-privileged docker container#23christf wants to merge 2 commits into
christf wants to merge 2 commits into
Conversation
Only set rp_filter to 0 if it contains a different value when initializing new interfaces. This is helpful to run babeld inside docker without --privileged
Owner
|
Why is the test not needed in the !setup branch of the if? |
Contributor
Author
|
On Thu, Oct 25, 2018 at 05:47:52PM +0000, Juliusz Chroboczek wrote:
Why is the test not needed in the !setup branch of the if?
Whether it is necessary or not is not entirely clear.
I did not touch the !setup branch because there the return code of
the function is discarded in the caller when tearing down interfaces.
There will still be a warning issued but babeld will continue to work
fine.
Thinking about this again, it is likely cleaner to do this properly.
Fortunately there already is a check in place that just needs minor
tweaking.
…--
() ascii ribbon campaign - against html e-mail
/\ against proprietary attachments
|
Owner
|
Thanks, applied with minor tweaks (in branch xroute-nlogn, soon to become master). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only set rp_filter to 0 if it contains a different value when
initializing new interfaces. This is helpful to run babeld inside docker
without --privileged.