Skip to content

first crack at some testing#64

Merged
jdalrymple merged 1 commit into
jdalrymple:gitlabcifrom
arsdehnel:gitlabci
Apr 19, 2018
Merged

first crack at some testing#64
jdalrymple merged 1 commit into
jdalrymple:gitlabcifrom
arsdehnel:gitlabci

Conversation

@arsdehnel

Copy link
Copy Markdown
Contributor

This is by no means intended to be merged. This was just meant to get a starting point out there and see what you think. Added some brief words on the readme about how to fire it up for testing. I'm using jest to run the tests which is what we use at work all the time so it's just what I'm familiar with. Otherwise this is a super basic test just proving out that it can run and hit the dockerized gitlab.

@jdalrymple

Copy link
Copy Markdown
Owner

This is really cool! Reading up on jest now :o

@jdalrymple

jdalrymple commented Apr 10, 2018

Copy link
Copy Markdown
Owner

Should devise a way to preconfigure the gitlab build to already have a token available

@arsdehnel

Copy link
Copy Markdown
Contributor Author

Yup, agreed. Wanted to make sure the rest of the approach seems good before spending too much time on it.

@jdalrymple

Copy link
Copy Markdown
Owner

The only thing I'd change is the folder structure, and maybe switching to a tap reporter because I for some reason really like tap 🤣 but besides that looks really good. Would travis ci then be responsible for spinning up the gitlab instance through docker compose and then running the library against it. Or would the getting the library into the container also be part of a docker compose file ?

@jdalrymple

Copy link
Copy Markdown
Owner

I added more tests to the gitlabci branch! 😄

@jdalrymple jdalrymple merged commit cb222cf into jdalrymple:gitlabci Apr 19, 2018
@jdalrymple

Copy link
Copy Markdown
Owner

Weird, tried to merge my changes into your remote branch and that autoclosed the PR. hmmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants