Skip to content

Fix import error#473

Closed
istrebitel-1 wants to merge 3 commits into
jd:mainfrom
istrebitel-1:bugfix/import-error
Closed

Fix import error#473
istrebitel-1 wants to merge 3 commits into
jd:mainfrom
istrebitel-1:bugfix/import-error

Conversation

@istrebitel-1

Copy link
Copy Markdown
  • If library installed from pypi, import were not correct

- If library installed from pypi, import were not correct
@mergify

mergify Bot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

Comment thread tenacity/__init__.py Outdated


from tenacity.asyncio import AsyncRetrying # noqa:E402,I100
from tenacity._asyncio import AsyncRetrying # noqa:E402,I100

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, there's no _asyncio module in the repo.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, you are right, but I still unable to import from installed lib
image
image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in library generation, asyncio module now not creating

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximlt check again pls

@Tenzer

Tenzer commented Jun 17, 2024

Copy link
Copy Markdown

I have narrowed it down to be due to the setuptools configuration: #471 (comment)

- Add asyncio to build package
@istrebitel-1

Copy link
Copy Markdown
Author

I have narrowed it down to be due to the setuptools configuration: #471 (comment)

yes, got same solution

- Added changelog
@jd

jd commented Jun 17, 2024

Copy link
Copy Markdown
Owner

Should be fixed by #474

@jd jd closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants