Skip to content

Shamir's secret sharing fixes & improvements #291

@simlei

Description

@simlei

Shamirs Secret Sharing

Bugs

Select (Coefficient)

  • Dialog layout is not GridLayout or does other things that do not scale well with DPI. Intended display + buggy display:
    image
    image
  • Verifying correct prime button does not work nor does the dialog update it's completeable state (OK button grey even with prime e.g. 23)
  • Upon entering an invalid value for s, e.g. 91, "Secret verification" comes up.
    • Again, the DPI problem (hides "Validate button")
    • Validate works here, but the dialog should update the OK button automatically here, too.

Visualization (Graph)

Improvement

Textual

Online help

  • Online help update (especially for English)

GUI

Dialogs

  • "Module" ==> "Modulus"
  • Coefficient "Select" -> Shell title ==> "Prime number verification" / "Primzahl-Überprüfung"
  • The secret s is bigger than the module p ==> The secret s is bigger than the modulus p. Please ensure: s < p.
  • Dialog title: "Geheimnis" --> "Geheimnis-Überprüfung", "Secret" --> "Secret verification"

Bescheibung oben

  • seinen eigenen ==> ihren eigenen
  • remove last sentence
  • Module ==> Modulus
  • Coefficient: ==> Coefficients:

GUI

  • Modul ==> Modulus
  • Koeffizient: ==> Koeffizienten:

Images for bugs

I1)

Shamir1

I2)

dplnknhcoapdceja

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions