Return CompletableFutures for public-facing operations - #757
Merged
Conversation
Owner
Author
|
I should also point out that this pull request highlights how much non-IO stuff we're inadvertently doing on IO threads. I'll open a follow-up pull request to add an "insulation" layer. |
jchambers
force-pushed
the
completable-future
branch
from
March 7, 2020 20:35
2de735a to
72bfab5
Compare
Owner
Author
|
Also, I'm trying to figure out how to describe the action of calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #746, this pull request replaces all public-facing uses of
io.netty.util.concurrent.Futurewithjava.util.concurrent.CompletableFuture.CompletableFutureis part of the stock Java SDK and offers all of the affordances—most importantly being able to add listeners—that Netty'sFutureoffers.