This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Setup annotation processor options from maven compiler plugin config values#1
Closed
lorenzhawkes wants to merge 3 commits intojbosstools:masterfrom
Closed
Setup annotation processor options from maven compiler plugin config values#1lorenzhawkes wants to merge 3 commits intojbosstools:masterfrom
lorenzhawkes wants to merge 3 commits intojbosstools:masterfrom
Conversation
compilerArgument and compilerArguments elements of the maven compiler plugin. The compilerArguments map simply looks for options that begin with -A. The compilerArgument string is parsed looking for strings that match the form -Akey[=value]
the compiler arguments config, since they can not be specified there correctly. Renamed some methods to make their purpose clearer. removed the isProcNone method and replaced it with isAnnotationProcessingEnabled. This now looks for the -proc:none in the compilerArgument element or the proc config element containing none. If one of those is present in all configured compilers then annotation processing is disabled.
Member
|
That looks ok. Now can you please :
|
fbricon
pushed a commit
that referenced
this pull request
Apr 23, 2012
Attempt to parse out annotation processor arguments from the compilerArgument element of the maven compiler plugin. The compilerArgument string is parsed looking for strings that match the form -Akey[=value] N.B. This method was cherry-picked from #1 - Fred Signed-off-by: Fred Bricon <fbricon@gmail.com>
Member
|
Since adding support for org.bsc.maven:maven-processor-plugin required quite some refactoring (3c6bf77), that pull request is out-of date, so I used your compilerArgument parsing method directly, kept you as the author. Thanks. |
Contributor
Author
|
Thanks for your help Fred |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compilerArgument and compilerArguments elements of the maven compiler
plugin.
The compilerArguments map simply looks for options that begin with -A.
The compilerArgument string is parsed looking for strings
that match the form -Akey[=value]