-
-
Notifications
You must be signed in to change notification settings - Fork 636
🧪 Start testing under Python 3.14(t) in CI #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This allows selecting free-threaded Python versions.
4ef2ed2 to
31bd0d2
Compare
|
Outside the scope of this PR, but this commit updating one of the testing packages to use |
|
Thanks for the ref! AFAICS, old pip + python 3.14 is the combo that fails. This is what PDB gives me: tests/test_cli_compile.py::test_editable_package[legacy resolver] FAILED
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
pip_conf = '/tmp/pytest-of-<username>/pytest-19/test_editable_package_legacy_r0/pip.conf', runner = <click.testing.CliRunner object at 0x7fc9c575a200>
def test_editable_package(pip_conf, runner):
"""piptools can compile an editable"""
fake_package_dir = os.path.join(PACKAGES_PATH, "small_fake_with_deps")
fake_package_dir = path_to_url(fake_package_dir)
with open("requirements.in", "w") as req_in:
req_in.write("-e " + fake_package_dir) # require editable fake package
out = runner.invoke(cli, ["-n"])
> assert out.exit_code == 0
E assert 1 == 0
E + where 1 = <Result InstallationError("file://~/src/github/jazzband/pip-tools/tests/test_data/packages/small_fake_with_deps (from -r requirements.in (line 1)) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.")>.exit_code
~/src/github/jazzband/pip-tools/tests/test_cli_compile.py:526: AssertionError
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PDB >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> PDB post_mortem >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> ~/src/github/jazzband/pip-tools/tests/test_cli_compile.py(526)test_editable_package()
-> assert out.exit_code == 0
(Pdb) pp out.output
('WARNING: the legacy dependency resolver is deprecated and will be removed in '
'future versions of pip-tools.\n')
(Pdb) pp out.stderr
('WARNING: the legacy dependency resolver is deprecated and will be removed in '
'future versions of pip-tools.\n')
(Pdb) pp out.stdout
''
(Pdb) pp out.exception
InstallationError("file://~/src/github/jazzband/pip-tools/tests/test_data/packages/small_fake_with_deps (from -r requirements.in (line 1)) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.")
(Pdb) pp out.exc_info
(<class 'pip._internal.exceptions.InstallationError'>,
InstallationError("file://~/src/github/jazzband/pip-tools/tests/test_data/packages/small_fake_with_deps (from -r requirements.in (line 1)) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found."),
<traceback object at 0x7fc9c4931000>)
(Pdb) pp pathlib.Path('requirements.in').read_text()
('-e '
'file:~/src/github/jazzband/pip-tools/tests/test_data/packages/small_fake_with_deps')I'm wondering if we should skip this test in broken envs or make actual changes... Or perhaps set a different minimum version of pip for py314. |
|
I'm going to move this to the v7.5.3 milestone (along with a few other items I'm moving over). We should start testing on 3.14 soon, but I don't want us to treat this as a blocker. Maybe we drop 3.8 and update our lowest supported |
|
Sure, maybe. |
Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".Maintainer checklist
skip-changeloglabel.