Skip to content

add 'milliseconds' to duration javadoc#119

Merged
tresf merged 2 commits intojava-native:masterfrom
aSemy:patch-1
Jan 9, 2022
Merged

add 'milliseconds' to duration javadoc#119
tresf merged 2 commits intojava-native:masterfrom
aSemy:patch-1

Conversation

@aSemy
Copy link

@aSemy aSemy commented Sep 25, 2021

I haven't checked if it is actually milliseconds! See #73 for more info.

Resolve #73

TODO

  • confirm that duration is in milliseconds

@tresf
Copy link

tresf commented Jan 9, 2022

#73

The unix source code calls a second "duration / 1000", then converts to nanoseconds calling nanosleep.

int sec = (duration >= 1000 ? duration/1000 : 0);

The windows source code calls Sleep(), which is nanoseconds.

Confirmed. :)

@tresf tresf merged commit 6886b44 into java-native:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javadocs for sendBreak() should indicate units for duration value

2 participants